Sketch Lab: manual pass on start mode colors#73458
Open
molly-moen wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some levels in sketch lab that had hard-coded colors that would not show up correctly in dark mode. This fixes the colors to at a minimum be readable in dark mode.
I used Claude to do a pass over the React Flow-based start sources and find colors that could be converted (building off #73424). Then I went through each level and did some manual fixes when the script didn't get things quite right--for example, the wireframe levels needed a colored background so the static black images will show up, and there's a few levels with a static white image that we need hard-coded black text on.
Before
After
Links
Testing story
Tested locally. I manually reviewed each change.