stop certificate ui tests from depending on prod courses in the db#73404
Draft
davidsbailey wants to merge 12 commits into
Draft
stop certificate ui tests from depending on prod courses in the db#73404davidsbailey wants to merge 12 commits into
davidsbailey wants to merge 12 commits into
Conversation
Use allthethingscourse L24/9 (Star wars #9, free-play, skin hoc2015) in place of courses/starwars/units/1/lessons/1/levels/15. The ar-sa RTL Applitools snapshot will need a one-time re-baseline on drone (course-header chrome differs). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use allthethingscourse L24/7 (Star wars #7) in place of courses/starwars/units/1/lessons/1/levels/5; pairing is course-independent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Navigate to allthethingscourse unit 1 lesson 37 level 8 (Dance_Party_12) instead of dance unit 1 lesson 1 level 13 -- the same Dance Lab level. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use allthethingscourse L7/2 (flappy_11, freePlay) in place of /flappy/10, which resolves to the same flappy_11 freeplay level. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Background navigates to allthethingscourse L7/2 (flappy_11) instead of /flappy/10 (same freeplay level). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use allthethingscourse L7/1 (flappy_1) for all three /flappy/1 references; same level, so the hardcoded YouTube id still matches. The @eyes 'Fallback player' snapshot needs a one-time drone re-baseline. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use ui-test-csf/units/1 as the non-AI unit page in place of courses/flappy/units/1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Second navigation (cookie-persistence check) now uses allthethingscourse L37/5 (Dance Lab #5) instead of courses/dance/units/1/lessons/1/levels/9. Line 3 was already on allthethings L37/1; this clears the last live courses/dance reference. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
No running UI test references either course any more: all courses/<slug> and tutorial-root URLs were repointed onto allthethingscourse (and ui-test-csf). The surviving references are seeding-independent -- /projects/{starwars,dance} standalone routes (global template levels), the create-dropdown / make-project project-type options, a @Skip footer scenario, an eyes snapshot label, and an href-string check. The dance/starwars levels that allthethings reuses stay seeded globally via custom_levels regardless of this script removal.
[reset db] so drone wipes and reseeds the DB, the only way a seed removal is actually validated.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use ui-test-artist (course=dWktdGVzdC1hcnRpc3Q%3D) instead of oceans (b2NlYW5z) for the bulk-print certificate scenario. /certificates/batch validates the course name against seeded CourseVersions, so this was the one cert test that genuinely required oceans seeded. Verified functionally against test-studio (eyes disabled); the bulk-print Applitools snapshot needs a one-time re-baseline on CI (generic HOC cert replaces the oceans cert). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
No running UI test requires either course seeded. The hoc_certificates.feature flappy and oceans cert scenarios enter via /api/hour/finish/<course>, which renders through the congrats third-party branch + a name-string cert template -- neither needs the course in the DB (the flappy case was confirmed empirically on circle/58388). The one path that validated a seeded course, the oceans bulk-print batch scenario, was just repointed to ui-test-artist. Remaining refs (/api/hour/finish, /projects/flappy) are seeding-independent. [reset db] so drone wipes and reseeds the DB to validate the removal. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
55b1631 to
8192ef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
Testing story
Deployment notes