Skip to content

Add Codebridge code suggestions setting#73401

Draft
ebeastlake wants to merge 1 commit into
stagingfrom
task/codebridge-code-suggestions-setting
Draft

Add Codebridge code suggestions setting#73401
ebeastlake wants to merge 1 commit into
stagingfrom
task/codebridge-code-suggestions-setting

Conversation

@ebeastlake

@ebeastlake ebeastlake commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a persisted Codebridge editor setting for Code suggestions, defaulting to On
  • add the setting to the Codebridge settings menu as On/Off
  • skip CodeMirror's autocompletion extension when the setting is Off

Testing

  • PASS: ./tools/hooks/pre-commit
  • PASS: PATH=/Users/ebeastlake/.rbenv/shims:$PATH git commit ... commit hooks
  • PASS: /Users/ebeastlake/.rbenv/shims/bundle exec ruby -Itest ./test/controllers/user_preferences_controller_test.rb
  • FAIL, unrelated local generated typing issue: yarn test:unit test/unit/codebridge/Editor/EditorTest.tsx fails before loading the test on src/util/globalEdition.ts (Regions[GlobalEditionDefaultRegion], missing us key)
  • FAIL, unrelated existing/local generated typing issues: yarn run typecheck fails in generated/shared constants, Blockly, Dance AI, and global edition files outside this change

Notes

  • This adds user_preferences.editor_settings. The commit hook printed the standard migration warning for adding a column; please sanity-check whether this needs infra review for production DDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant