Skip to content

Repoint starwars dance flappy UI tests#73392

Open
davidsbailey wants to merge 10 commits into
stagingfrom
repoint-starwars-dance-flappy-ui-tests
Open

Repoint starwars dance flappy UI tests#73392
davidsbailey wants to merge 10 commits into
stagingfrom
repoint-starwars-dance-flappy-ui-tests

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Jun 22, 2026

Copy link
Copy Markdown
Member

This PR is part of the effort to move UI tests off of production courses.

Done in this PR:

  • move a bunch more UI tests to point at existing levels in allthethings, including some that were recently added for this purpose.
  • stop seeding some courses during UI tests, for those courses which are no longer being depended on by any ui tests.

Links

Testing story

  • modified tests are passing in drone

Deployment notes

  • remove starwars and dance courses from test-studio, which may cause some eyes diffs

davidsbailey and others added 10 commits June 22, 2026 20:52
Use allthethingscourse L24/9 (Star wars #9, free-play, skin hoc2015) in place of courses/starwars/units/1/lessons/1/levels/15. The ar-sa RTL Applitools snapshot will need a one-time re-baseline on drone (course-header chrome differs).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use allthethingscourse L24/7 (Star wars #7) in place of courses/starwars/units/1/lessons/1/levels/5; pairing is course-independent.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Navigate to allthethingscourse unit 1 lesson 37 level 8 (Dance_Party_12) instead of dance unit 1 lesson 1 level 13 -- the same Dance Lab level.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use allthethingscourse L7/2 (flappy_11, freePlay) in place of /flappy/10, which resolves to the same flappy_11 freeplay level.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Background navigates to allthethingscourse L7/2 (flappy_11) instead of /flappy/10 (same freeplay level).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use allthethingscourse L7/1 (flappy_1) for all three /flappy/1 references; same level, so the hardcoded YouTube id still matches. The @eyes 'Fallback player' snapshot needs a one-time drone re-baseline.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use ui-test-csf/units/1 as the non-AI unit page in place of courses/flappy/units/1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Second navigation (cookie-persistence check) now uses allthethingscourse L37/5 (Dance Lab #5) instead of courses/dance/units/1/lessons/1/levels/9. Line 3 was already on allthethings L37/1; this clears the last live courses/dance reference.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
No running UI test references either course any more: all courses/<slug> and tutorial-root URLs were repointed onto allthethingscourse (and ui-test-csf). The surviving references are seeding-independent -- /projects/{starwars,dance} standalone routes (global template levels), the create-dropdown / make-project project-type options, a @Skip footer scenario, an eyes snapshot label, and an href-string check. The dance/starwars levels that allthethings reuses stay seeded globally via custom_levels regardless of this script removal.

[reset db] so drone wipes and reseeds the DB, the only way a seed removal is actually validated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@davidsbailey davidsbailey marked this pull request as ready for review June 23, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant