Drop Cdo wrapper from AWS::DeviceFarm module#73382
Open
davidsbailey wants to merge 1 commit into
Open
Conversation
device_farm.rb declared `module Cdo; module AWS; module DeviceFarm`, out of step with its siblings cloud_formation.rb, ec2.rb, s3.rb, and cloudfront.rb, which all declare a top-level `module AWS`. Collapse to `module AWS; module DeviceFarm` to match. device_farm.rb was the only file creating a Cdo::AWS namespace, so its removal lets two now-unnecessary `::AWS` scope-resolution operators in playwright_report.rb fall back to the bare `AWS` (which resolves to the top-level module from inside `module Cdo`); the comments explaining the defense go with them. connect.rb's callers move from Cdo::AWS::DeviceFarm to AWS::DeviceFarm, matching the AWS::EC2 reference already in that file. The SDK's `::Aws::DeviceFarm` references (case-distinct, lowercase) stay explicit and untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device_farm.rb declared
module Cdo; module AWS; module DeviceFarm, breaking repo convention of declaring top-levelmodule AWS. Collapse tomodule AWS; module DeviceFarmto match.device_farm.rb was the only file creating a Cdo::AWS namespace, so its removal lets two now-unnecessary
::AWSscope-resolution operators in playwright_report.rb fall back to the bareAWSThe SDK's
::Aws::DeviceFarmreferences (case-distinct, lowercase) stay explicit and untouched.Testing story