Change flow for Learn To Evaluate Tour#73380
Open
kobryan0619 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the “Learn How to Evaluate” onboarding tour on the teacher homepage/progress flow by removing the branching choice from the Student Snapshot “AI insights” step and converting it into a linear “Next”-driven sequence.
Changes:
- Replaced the AI insights step’s two branching buttons with a single
Nextbutton and updated the step copy accordingly. - Reordered the snapshot sub-steps so the tour progresses linearly via
tour.next(). - Updated the unit test to reflect the new single-button behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/src/templates/studioHomepages/teacherHomepageV2/learnHowToEvaluateOnboarding.ts | Removes branching UI from the AI insights step, switches to Next, and adjusts snapshot step ordering for linear flow. |
| apps/test/unit/templates/studioHomepages/teacherHomepageV2/learnHowToEvaluateOnboardingTest.ts | Updates the test to expect one button and verify it advances the tour via next(). |
Comment on lines
268
to
272
| const step = steps.find( | ||
| s => s.id === STUDENT_SNAPSHOT_AI_INSIGHTS_STEP_ID | ||
| )!; | ||
| const buttons = step.buttons as {text: string; action: () => void}[]; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this conversation, we are changing this flow to have less branching and just a series of "next" options.