chore(apps): remove dead files (DonorTeacherBanner, CachedElement, Headings)#73358
Open
levadadenys wants to merge 1 commit into
Open
chore(apps): remove dead files (DonorTeacherBanner, CachedElement, Headings)#73358levadadenys wants to merge 1 commit into
levadadenys wants to merge 1 commit into
Conversation
Remove unreferenced components and their paired test/story files. - apps/src/templates/DonorTeacherBanner.jsx: no importers; the DonorTeacherBanner* names in frontend/packages/core API schemas are unrelated zod types. - apps/src/util/CachedElement.jsx and its test: the test was the only consumer. - apps/src/legacySharedComponents/Headings.jsx and its story file: components are marked @deprecated in favor of DSCO Typography and no longer imported. The story file imports MUI Typography, not these components. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NaqHRUC9QeQjX2EMdBwzuw
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused legacy React components and their associated test/story files from apps/, reducing dead code in the dashboard frontend bundle and test suite.
Changes:
- Deleted unused
CachedElementutility component and its unit test. - Deleted unused legacy
Headingscomponents and their Storybook story. - Deleted unused
DonorTeacherBannertemplate component.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/test/unit/util/CachedElementTest.jsx | Removed unit test for CachedElement, which no longer exists. |
| apps/src/util/CachedElement.jsx | Removed unused HTML-caching utility component. |
| apps/src/templates/DonorTeacherBanner.jsx | Removed unused legacy banner component tied to an older dismissal endpoint. |
| apps/src/legacySharedComponents/Headings.story.jsx | Removed Storybook story for legacy headings. |
| apps/src/legacySharedComponents/Headings.jsx | Removed deprecated legacy heading wrapper components/styles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes three unreferenced components and their paired test/story files from
apps/. Each was verified to have no importers acrossapps/,frontend/, anddashboard/.apps/src/templates/DonorTeacherBanner.jsx— class component with no importers. TheDonorTeacherBanner*names that appear infrontend/packages/core/src/api/dashboard/users/are unrelated zod schemas/types for the API (e.g.DonorTeacherBannerDetailsSchema), not consumers of this JSX component.apps/src/util/CachedElement.jsxandapps/test/unit/util/CachedElementTest.jsx— the test was the component's only consumer; both are removed together.apps/src/legacySharedComponents/Headings.jsxandapps/src/legacySharedComponents/Headings.story.jsx— theHeading1/Heading2/Heading3components are marked@deprecated Use DSCO Typography insteadand are no longer imported anywhere. The sibling story file already renders MUITypographyrather than these components, and thetypography-to-mui.jscodemod only carries the names in a transformation map (no import).595 lines deleted, no other changes.
Test plan
grepacrossapps/,frontend/,dashboard/)Generated with Claude Code.
Generated by Claude Code