Extract apps_build_trigger_paths to deployment.rb#73339
Merged
Conversation
Move apps_build_trigger_paths out of lib/rake/build.rake into deployment.rb so it can be shared. The apps S3Packaging source_locations in lib/rake/package.rake now references this single list instead of its own hard-coded [apps_dir, frontend_dir], so the paths that trigger an apps build and the paths that determine the package commit hash stay in sync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
stephenliang
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move apps_build_trigger_paths out of lib/rake/build.rake into deployment.rb so it can be shared. The apps S3Packaging source_locations in lib/rake/package.rake now references this single list instead of its own hard-coded [apps_dir, frontend_dir], so the paths that trigger an apps build and the paths that determine the package commit hash stay in sync.
Testing story
apps_dirandfrontend_dir, which are also defined in deployment.rb, so it seems reasonable to assume it can now referenceapps_build_trigger_pathsDeployment notes
Generated different package for same contentswarnings on staging / test