Avoid a TypeError in isTextSafe when the model returns no output#73317
Open
cnbrenci wants to merge 1 commit into
Open
Avoid a TypeError in isTextSafe when the model returns no output#73317cnbrenci wants to merge 1 commit into
cnbrenci wants to merge 1 commit into
Conversation
isTextSafe read response.output.classification directly, which throws a raw TypeError when the gateway returns no structured output. Use optional chaining so classification falls through to the existing "Invalid classification value" guard instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
isTextSafereadresponse.output.classificationdirectly. When the AI gateway returns no structured output (response.outputisundefined), that throws a rawTypeError("Cannot read properties of undefined") instead of the intended error.Use optional chaining (
response.output?.classification) so an undefined output falls through to the existing guard, which throws a clearInvalid classification value: undefined.Testing
One-line defensive change; no behavior change when output is present. Covered by the existing safety-helpers path; drone runs the unit suite.
🤖 Generated with Claude Code