test(e2e): port level_types/multi to playwright#73287
Open
stephenliang wants to merge 2 commits into
Open
Conversation
Port 3 scenarios from level_types/multi.feature. Green under the 5x/all-browser stress gate; original Cucumber feature tagged @playwright so the Cucumber suite skips it. Source: level_types/multi.feature
Review follow-up to the level_types/multi port, scoped to the port's own files: - Rename MultiLab -> MultiLevel; move the spec to tests/levels/. multi is a Level (dashboard/app/models/levels/multi.rb), not a lab or an activity. - Collapse submit()/submitLast() to one submit() and drop the doubled first()/last() assertions; there is exactly one .submitButton. - Add an optional lang param to labLevelUrl and delete the gotoUrl escape hatch. - Drop the no-op rotateLandscape helper; the project viewport is already landscape. - Drop the win-modal-title assertion, which the source feature never had. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
a450c93 to
bdfdb77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
level_types/multiCucumber feature to Playwright in@code-dot-org/e2e-tests.Scenarios (→
tests/levels/multi.spec.ts):The source feature is tagged
@playwrightso the Cucumber suite skips it (nodouble-running).
Structure and naming:
MultiLevel, spec lives undertests/levels/.multiis aLevel (
dashboard/app/models/levels/multi.rb), not a lab or an activity —those are distinct concepts in our domain model.
langparamon
labLevelUrl(defaultundefined→ byte-identical URLs for existingcallers), rather than a hand-built URL.
The change is scoped to its own new files plus that one additive
labLevelUrlparam, so no other spec's behavior changes.
Links
dashboard/test/ui/features/teacher_tools/level_types/multi.featureTesting story
test-studio.code.orgacross all three browsers(chromium, firefox, webkit): 9/9 green.
runs).
yarn typecheckandyarn lintclean; repopre-commithook clean.🤖 Generated with Claude Code