Update international_partners_data.json#73276
Open
cordova-karina wants to merge 1 commit into
Open
Conversation
Need to include CodeAI for all countries, since we will start training teacher directly
carl-codeorg
left a comment
Contributor
There was a problem hiding this comment.
Hey @cordova-karina - if the intent is to add CodeAI to every country's list in the UI, would it be acceptable to automatically add the CodeAI value when we parse the JSON in the InternationalOptIn::PartnerDataLoader service? This would automate the addition of CodeAI without adding it to each individual list in the JSON. If that sounds good, let me know and I can draft a PR.
Author
|
That sounds good to me! appreciate your help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to include CodeAI for all countries, since we will start training teachers directly
Links
Testing story
Deployment notes
Privacy and security