feat(global-edition): autoinclude GE path prefix in Rails generated URLs#73059
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2d7439fd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a2d7439 to
ab2bf21
Compare
ab2bf21 to
36a4401
Compare
0328b07 to
a16fc5a
Compare
wilkie
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically adds the active Global Edition path prefix to Rails generated URLs.
Controllers, views, and helpers already get this behavior through
request.script_name, which is set byMiddleware::GlobalEdition. However, route helpers can also be called from places without direct access to the request object, such as models or background logic:code-dot-org/dashboard/app/models/unit_group.rb
Lines 385 to 391 in 0328b07
This change makes generated paths respect the active Global Edition region for the current request through
Cdo::GlobalEdition.current_region, while preserving any explicitly providedscript_name. For example: