Student Scrapbook V1 #72964
Conversation
… user menu, change to thumbtack icon
|
This is so exciting @Erin007 ! Excited for @moshebaricdo's thoughts on the placement of the entry points. Knowing student nav is likely on the docket for next year I want to stress test with @jamjamgobambam that we feel comfortable adding an entry via the header but it does make sense to me from an IA perpective that this would travel with the student |
| background: #e0d4f5 !important; | ||
| color: #4b2a8a !important; |
There was a problem hiding this comment.
Can we use semantic colors here?
There was a problem hiding this comment.
Also obligatory "do we have to use !important"?
| </Provider>, | ||
| scrapbookMountPoint, | ||
| { | ||
| legacyReactDomRender: true, |
There was a problem hiding this comment.
just for my knowledge, what does this do?
There was a problem hiding this comment.
Ideally, we should check in migrations ahead of the code changes that use them.
bethanyaconnor
left a comment
There was a problem hiding this comment.
I know this is an early implementation but it would be great to see some tests here. Historically, we're not great about going back and adding them.
Also should we add any guardrails on storing images in the DB? I'm pretty okay with the plan of not trying to wrangle S3 here, though that's a bridge we'll probably want to cross if we move forward here.
|
Empty state message |
| 90deg, | ||
| #e57373, | ||
| #ffb74d, | ||
| #fff176, | ||
| #81c784, | ||
| #64b5f6, | ||
| #9575cd, | ||
| #ba68c8 |
There was a problem hiding this comment.
we may have to update this with the rebrand but given this is a gradient, I'm assuming that's unavoidable.
|
|
||
| return ( | ||
| <> | ||
| <button |
There was a problem hiding this comment.
Why not use the MUI button here?
bethanyaconnor
left a comment
There was a problem hiding this comment.
Thanks for adding the dashboard tests and saving to S3!
I'd still ideally like to see some tests for the server side components for things like opening the dialog and mocking out the scrapbook save.
I also would still like the migration to be pulled into its own PR ahead of this one, especially given how large this PR has become.
Proposal
This is a new feature born at the Code Connect hackathon to capture students' key learning takeaways as they work through CodeAI lessons or projects. Behind an experiment flag
student-scrapbookthere is now a thumbtack icon that opens a dialog where students can enter details about how their thinking changed and include before and after pictures as evidence. There is also a link in the user menu that takes the student to a "My scrapbook" page that is a gallery of all of their scrapbook entries. This is an early implementation that we intend to use to gather signal from students and teachers over the summer about if and how we should integrate the feature more fully into our product and curriculum.🎥 Video walkthrough