Don't try to get control ID unless we're going to show it.#7276
Merged
Conversation
Contributor
|
lgtm |
islemaster
added a commit
that referenced
this pull request
Mar 14, 2016
Don't try to get control ID unless we're going to show it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an edge case in the new App Lab element id overlay, that could cause an uncaught exception when running the app.
I've run into this a few times - there seems to be an edge case where
getMouseoverApplabControlId_could be called in the mouse event before the React props got updated, leading to trouble when trying to retrieve the correct element id. I think it might also be connected to the weirdness where we can be in 'Design Mode' while running.Here I've taken a pretty simple approach of not even trying to get the id if we're not going to display it anyway (because we're running, or the mouse is outside the visualization).
Fix extracted from #7148
FYI @kozzi