Allow Overriding Local Webdriver Tests#67509
Merged
Hamms merged 3 commits intoAug 11, 2025
Merged
Conversation
Follow-up to #65064, which added logic to use a local webdriver for the first run of all UI and Eyes tests, only falling back to SauceLabs for any tests which fail that first run. This PR adds a commit flag which can be used to selectively override that behavior if a developer has a specific reason to want even passing tests to run in SauceLabs (for example, if they want to share a video of a newly-added UI test running successfully). [Slack thread](https://codedotorg.slack.com/archives/C08AMQ869QX/p1753933950644269)
hannahbergam
approved these changes
Aug 11, 2025
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
LGTM, and thank you! So this flag would be [skip local webdriver] (in brackets), right?
Contributor
Author
|
Yep! See this test commit for an example, and this comment for some (minimal) documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65064, which added logic to use a local webdriver for the first run of all UI and Eyes tests, only falling back to SauceLabs for any tests which fail that first run.
This PR adds a commit flag which can be used to selectively override that behavior if a developer has a specific reason to want even passing tests to run in SauceLabs (for example, if they want to share a video of a newly-added UI test running successfully).
Links
Slack thread
Testing story
Validated with an empty commit that with the new flag, all tests are run on saucelabs