Skip to content

feat(marketing): invalidate cache after deployment#65707

Merged
stephenliang merged 3 commits into
stagingfrom
stephen/invalidate-cache
May 13, 2025
Merged

feat(marketing): invalidate cache after deployment#65707
stephenliang merged 3 commits into
stagingfrom
stephen/invalidate-cache

Conversation

@stephenliang

@stephenliang stephenliang commented May 7, 2025

Copy link
Copy Markdown
Member

After deploying the marketing app, invalidate the cache to ensure the live content reflects the deployed application.


- name: "[Test] Invalidate CloudFront Cache"
env:
CLOUDFRONT_DISTRIBUTION_ID: ${{ vars.CLOUDFRONT_DISTRIBIUTION_ID }}

@sureshc sureshc May 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CLOUDFRONT_DISTRIBUTION_ID: ${{ vars.CLOUDFRONT_DISTRIBIUTION_ID }}
CLOUDFRONT_DISTRIBUTION_ID: ${{ vars.CLOUDFRONT_DISTRIBUTION_ID }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to confirm - I only see the addition of a space here which wouldn't be valid. Did you have a different review comment?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. sorry about that. fixed the missing space.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spelling of distribution is incorrect

@sureshc

sureshc commented May 7, 2025

Copy link
Copy Markdown
Contributor

During the transition period, will we also need to invalidate the cache on the Pegasus CloudFront Distribution?

@stephenliang

Copy link
Copy Markdown
Member Author

During the transition period, will we also need to invalidate the cache on the Pegasus CloudFront Distribution?

No, I don't think so. The invalidation makes changes visible instantly but we still have a SWR flag which will cause the pages to be refreshed after ~1-2 hours.

We'll have to test it some more once we have the full stack integration in place to ensure the caching mechanism works as expected, though.

@stephenliang stephenliang force-pushed the stephen/invalidate-cache branch from f876dd5 to 47a8c6c Compare May 13, 2025 20:57
@stephenliang stephenliang merged commit accef2e into staging May 13, 2025
5 of 6 checks passed
@stephenliang stephenliang deleted the stephen/invalidate-cache branch May 13, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants