[Denys Fork] Making WithTooltip and WithPopover update position dynamically#65294
Merged
levadadenys merged 7 commits intoMay 19, 2025
Merged
Conversation
8 tasks
🖼️ Storybook Visual Comparison Report✅ No Storybook eyes differences detected! |
hannahbergam
reviewed
May 2, 2025
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
Hi! We have a change in Pythonlab this would really benefit from this fix. Are you able to add screenshots here?
hannahbergam
approved these changes
May 16, 2025
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the videos!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2025. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
[Denys Fork] Making WithTooltip update position dynamically
This is a fork/subbranch of #65142
I took existing code as a base and made some polishing improvements, tooltips should now position as expected, with direction flipping when tooltip is out of screen.
Proposed deploy strategy: review/approve this pr -> merge it to #65142 -> merge Hannah's PR into staging
(all merges should be a merge commits, not squash merges. That will allow us to auto generate changelog)
2025-05-16.21.49.47.mov
2025-05-16.21.51.14.mov
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: