Skip to content

Adding instructions to keyboard navigate codemirror#65084

Closed
hannahbergam wants to merge 3 commits into
stagingfrom
hbergam/screenreader-announce
Closed

Adding instructions to keyboard navigate codemirror#65084
hannahbergam wants to merge 3 commits into
stagingfrom
hbergam/screenreader-announce

Conversation

@hannahbergam

@hannahbergam hannahbergam commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2025. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

This update provides visible and screenreader instructions to users regarding workspace navigation. According to WCAG, these instructions should be provided (if navigation is outside the typical tab structure) visible, either at the top or bottom of the space, on validation, or through a tooltip. We decided on a tooltip in this case, as it is least continually disruptive. I merged the WithTooltip update first to ensure the tooltip will be dismissable. I also fixed tooltip rendering so that it updates dynamically and does not overflow off the page.

For a mouse user, they will see the tooltip on hover. If they dismiss it, it will disappear (and will not appear again until the mouse leaves the space and then reenters). I chose the onRight approach because this is least likely to overlap anything imporant for the user.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam

Copy link
Copy Markdown
Contributor Author

Closing for now, as we are going to take a different approach here (and the instructions will be different because we updated the keyboard interactions with the code editor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant