Adding instructions to keyboard navigate codemirror#65084
Closed
hannahbergam wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Closing for now, as we are going to take a different approach here (and the instructions will be different because we updated the keyboard interactions with the code editor) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2025. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
This update provides visible and screenreader instructions to users regarding workspace navigation. According to WCAG, these instructions should be provided (if navigation is outside the typical tab structure) visible, either at the top or bottom of the space, on validation, or through a tooltip. We decided on a tooltip in this case, as it is least continually disruptive. I merged the WithTooltip update first to ensure the tooltip will be dismissable. I also fixed tooltip rendering so that it updates dynamically and does not overflow off the page.
For a mouse user, they will see the tooltip on hover. If they dismiss it, it will disappear (and will not appear again until the mouse leaves the space and then reenters). I chose the onRight approach because this is least likely to overlap anything imporant for the user.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: