Speculative fix for flaky flappydrag UI test (attempt #2)#63596
Merged
Conversation
sanchitmalhotra126
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 2nd attempt to fix the flaky
flappydragUI test. #63569 was reverted because the offset was too large on the iphone and ipad. I updated dy from60to35.Links
After update
Tested locally via Saucelabs.
Firefox
Chrome
iPad
iPhone
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: