Create student user at end of new signup flow#61616
Merged
Merged
Conversation
TurnerRiley
commented
Oct 10, 2024
Comment on lines
-19
to
-26
| import { | ||
| IS_PARENT_SESSION_KEY, | ||
| PARENT_EMAIL_SESSION_KEY, | ||
| PARENT_EMAIL_OPT_IN_SESSION_KEY, | ||
| USER_AGE_SESSION_KEY, | ||
| USER_STATE_SESSION_KEY, | ||
| USER_GENDER_SESSION_KEY, | ||
| } from './signUpFlowConstants'; |
Contributor
Author
There was a problem hiding this comment.
All of these fields are set on this page so it didn't really make sense to use sessionStorage for them
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
This looks right to me! And we still have a bunch of front end validation to ensure those fields don't get sent blank in the fetch right?
Contributor
Author
Yep the button isn't enabled until the required fields are filled in! |
hannahbergam
approved these changes
Oct 11, 2024
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
This looks right to me! Thanks for these tests!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates student user entry (and associated parent email preference entry if applicable) at the end of the new signup flow.
New student fills in all fields with a parent opting in to receiving emails
User entry:
Parent
EmailPreferenceentry:New student with a parent opting out of receiving emails
User entry:
Parent
EmailPreferenceentry:New student without a parent filling in only required fields (name, age, state)
User entry:
Links
Jira ticket: here
Testing story
Local testing and adding unit tests.