Defaulting to test wide timeout for reset progress for flaky test multiple_choice_contained_levels.feature#61512
Merged
Conversation
…tiple_choice_contained_levels.feature
lfryemason
approved these changes
Oct 3, 2024
lfryemason
left a comment
Contributor
There was a problem hiding this comment.
One thing to consider, otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two root causes for flakiness in multiple_choice_contained_levels.feature,
This PR focuses on #2 above. When looking at a few different test runs, the API call to
POST /delete_predict_level_progresstakes under 100 ms in successful cases, while in case of failures, the call takes over 2 seconds and in some cases the test exists before the call completes.While trying this scenario manually, I noticed a fairly long delay performing this action on test.
Fix: The test currently has an upper limit of 5 seconds for the action to complete and UI reflect the change. This change would remove the upper limit and have this step also fall back to the test wide timeout.
There is a follow up here worth pursuing if this helps but results in a large latency. Added that in this https://codedotorg.atlassian.net/browse/TEACH-1383 to track.
Links
JIRA https://codedotorg.atlassian.net/browse/TEACH-1383
Testing story
Drone
Deployment strategy
Regular DTP
Follow-up work
Privacy
Security
Caching
PR Checklist: