Skip to content

Revert "Revert "Add hourofcode.com to list of production environments on utils.js""#60838

Merged
kelbyhawn merged 3 commits into
stagingfrom
revert-60834-revert-60794-add-hoc-to-statsig-prod-list
Sep 5, 2024
Merged

Revert "Revert "Add hourofcode.com to list of production environments on utils.js""#60838
kelbyhawn merged 3 commits into
stagingfrom
revert-60834-revert-60794-add-hoc-to-statsig-prod-list

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Reverts #60834

The event logger was too far down in the DOM so the Statsig API was getting called before the data-statsig-api-client-key loaded. Was able to fix this w/ @hannahbergam's sleuthing skills by moving the event logger to the top of the file.

I also removed Amplitude from the HoC event logger so now we are only sending events to Statsig.

Can confirm events will send to Statsig:
Screenshot 2024-09-04 at 4 19 21 PM

Links

Jira ticket: ACQ-2357
Slack convo: hereacqs channel convo

@drizco drizco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! 🚀

@kelbyhawn kelbyhawn merged commit 2eb4fdd into staging Sep 5, 2024
@kelbyhawn kelbyhawn deleted the revert-60834-revert-60794-add-hoc-to-statsig-prod-list branch September 5, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants