Skip to content

[Google Blockly] controls_for_counter generator#60448

Merged
mikeharv merged 1 commit into
stagingfrom
mike/controls_for_counter
Aug 15, 2024
Merged

[Google Blockly] controls_for_counter generator#60448
mikeharv merged 1 commit into
stagingfrom
mike/controls_for_counter

Conversation

@mikeharv

Copy link
Copy Markdown
Contributor

During the Artist bug bash, @molly-moen identified a block that was causing an error due to a missing generator function:

image

With Blockly v10, these generator functions have been moved to generator.forBlock. The controls_for block and generator are provided with core Blockly, so we do not ever have them defined on the generator object itself. If the function isn't there, we can find it on forBlock.

Now the block can be used and generates code correctly.

image

Links

Bug bash doc: https://docs.google.com/document/d/14nGoZMVSptvDnRt1He0t6JQBRf-Em3ZcSIMUoEPYMq0/edit

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv requested a review from a team August 15, 2024 19:36
@mikeharv mikeharv merged commit 9dd4528 into staging Aug 15, 2024
@mikeharv mikeharv deleted the mike/controls_for_counter branch August 15, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants