[Google Blockly] controls_for_counter generator#60448
Merged
Merged
Conversation
molly-moen
approved these changes
Aug 15, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the Artist bug bash, @molly-moen identified a block that was causing an error due to a missing generator function:
With Blockly v10, these generator functions have been moved to
generator.forBlock. Thecontrols_forblock and generator are provided with core Blockly, so we do not ever have them defined on the generator object itself. If the function isn't there, we can find it onforBlock.Now the block can be used and generates code correctly.
Links
Bug bash doc: https://docs.google.com/document/d/14nGoZMVSptvDnRt1He0t6JQBRf-Em3ZcSIMUoEPYMq0/edit
PR Checklist: