Music player retrieves channel ids from featured projects#59028
Closed
fisher-alice wants to merge 26 commits into
Closed
Music player retrieves channel ids from featured projects#59028fisher-alice wants to merge 26 commits into
fisher-alice wants to merge 26 commits into
Conversation
This reverts commit e8c0830.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE: Closed PR due to commit history not resolving correctly and merging issues after base branch was merged with staging. Will open new PR.
This PR updates the retrieval of music lab projects for the music home page (https://code.org/music) so that they are pulled from active featured projects instead of from a hard-coded list. A DCDO flag is also added that can switch the retrieval to a pre-selected list of channel ids. This PR follows up #58973 which added music lab projects to featured projects.
Note that BEFORE this PR is merged, at least 5 music lab projects must be published, then bookmarked and then set to be active featured projects.
After update
This screenshot demos how active music lab featured projects are displayed in the music mini-player on the music home page.
First featured projects # 1-5 are displayed in the mini-player. Then from '/projects/featured' (the admin featured projects page), the active music lab featured projects are updated and this is reflected in the mini-player.
If there are more than 5 active featured projects, 5 are randomly selected and displayed.
after-update-music-featured.mp4
Note that for testing purposes, channel ids can still be retrieved from the channels param:
Links
jira
Testing story
I tested locally by creating 7 music lab projects. Then I published and bookmarked them using dashboard-console commands. Once bookmarked, the projects were displayed at 'projects/featured'. I confirmed that they were displayed in the mini-player when a music lab featured project was 'active', and then removed when it was unfeatured ('archived').
Deployment strategy
Follow-up work
Add Amplitude analytics to log number of plays occurring in the mini-player and include user id, channel id.
Privacy
Security
Caching
PR Checklist: