Fixing flaky UI test Firefox_teacher_tools_level_types_bubble_choice Viewing BubbleChoice progress#58431
Merged
Merged
Conversation
…Viewing BubbleChoice progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eyes test is flaky in two different instances, but both fail because of
"ReferenceError: $ is not defined".Root cause: The error indicate JQuery hasn't loaded. The failure happens right after a new page load. Although we have a check for JQuery to be loaded, in these failure cases, the check runs on the old page before navigating away from it to the new page.
Fix: Updating the navigation action to also wait for the new page load.
Links
JIRA https://codedotorg.atlassian.net/browse/TEACH-1042
Testing story
Drone runs
Deployment strategy
Regular DTP
Follow-up work
None
Privacy
N/A
Security
N/A
Caching
N/A
PR Checklist: