Scroll to bottom on new message, allow new lines#58392
Merged
Merged
Conversation
fisher-alice
approved these changes
May 6, 2024
fisher-alice
left a comment
Contributor
There was a problem hiding this comment.
Cool! Just a left a question for my own understanding. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated improvements to the chat UI:
Links
autoscroll.mov
Testing story
Tested manually (see video/screenshots above). I also noticed that this change preserves newlines in a user message as well (ie, if you hit shift+enter while entering a message, that newline is reflected in the chat workspace)