Revert "Revert "Datablock Storage: replace firebase for applab data features (#56279)"#57480
Merged
Conversation
Co-authored-by: Cassi Brenci <cnbrenci@users.noreply.github.com>
cnbrenci
approved these changes
Mar 22, 2024
cnbrenci
left a comment
Contributor
There was a problem hiding this comment.
Great to have test coverage for this now 🥳
Set tableType="shared" when dispatching addTableName() for live tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #57471 , which reverted the original datablock storage PR #56279 after it broke the
getColumnblock.Fix
getColumn(), which was producing debug console errors like "You tried to get a column called _ from a table called _ but that column doesn't exist.":applabCommands.getColumn(): now callsApplab.storage.getColumn()rather thanApplab.storage.readRecords()like it did before datablockStorage.js:Fix "Daily Weather" and "Spotify" current tables shows up with no records in the data browser:
For more details on datablock storage, see: #56279.