Fix reference for renamed method to be the new name#57467
Merged
Conversation
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me! Esp based on my guess here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honeybadger error showed up after DTP: https://app.honeybadger.io/projects/3240/faults/105874856/01HSHNHCTR8X7CJJ8NZJBB2X2M?q=occurred.after%3A%221+hours+ago%22
Bug is from this pr #56279
I believe there is no user impact. I'm able to successfully export an applab project without seeing any error, and my project works after it's been exported. I believe the only effect of this bug is that firebase options don't get included in the exported project which is fine because we don't support execution of the data functions in exported projects anyway.
Testing story
I can repro the 500 error in prod on one of my projects with this URL: https://studio.code.org/projects/applab/gqD0R_uAxZXeExUWMZDCGfAjSgyQIZknpKGr9VJ3_bE/export_config?script_call=setExportConfig
With the fix, http://localhost-studio.code.org:3000/projects/applab/TP3c4-GKEI4pvQ5HayE-1w/export_config?script_call=setExportConfig is successful.