INF-979 Prefactor docker code to prepare for additional dockerfiles and images#57243
Merged
Conversation
…arin/docker-prefactor
unlox775-code-dot-org
approved these changes
May 21, 2024
cat5inthecradle
commented
Jun 5, 2024
|
|
||
| ``` | ||
| docker tag <image_id> codedotorg/code-dot-org:<version> | ||
| docker tag <image_id> codedotorg/cdo-drone:<version> |
Contributor
Author
There was a problem hiding this comment.
We don't define what are versioning scheme is. I'd suggest a simple incrementing integer, or a date based scheme.
wilkie
approved these changes
Jul 16, 2024
Contributor
|
Given how many lines of code we have that still reference Circle CI, I think I'd prefer that we name things |
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our existing dockerfile builds an image suitable for Drone tests and perhaps local development, but it's not great for production workloads. In preparation for adding additional Docker options, this PR removes the presumption that this is the only or primary dockerfile, making room for additional dockerfiles.
For example, I am working on a 'minimal' or 'dependencies only' Dockerfile that contains only system dependencies for building and running the rails application. It will not contain developer tools, a mysql server, or testing dependencies like browser drivers.
Two major things are happening here:
codedotorg/code-dot-orgtocodedotorg/cdo-drone. Chosing this name vs justdronebecause it's an image of thecode-dot-orgapplication,cdofor brevity, prepared specially for executing in drone. Future images might becdo-minimalandcdo-activejoborcdo-dashboard.Links
Testing story
Deployment strategy
Follow-up work
After merging this, a new image should be pushed to Docker Hub with the new naming convention. After this is pushed, we can create a new Pull Request that updates the docker compose files and the drone configuration to use the new image. Then we can complete all the 'TODO' items in this PR.
Privacy
Security
Caching
PR Checklist: