Rework DatablockStorage methods to not use Firebase-isms#56471
Merged
Conversation
Firebase still uses type argument, since it can't check on the backend.
Will permit future search cleanups to be more confident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing API was Firebase-centric in a few namings/ways. This PR converts the API to be strictly DatablockStorage-centric, using
isFirebaseStorage()guard checks to use different function names / params. This way, we can search forisFirebaseStorage()andisDatablockStorage()after final deployment, and by removing them, the resulting code will make sense, e.g. not be referencing subscriptions and other Firebase concepts.AS OF THIS PR THE APIS OF
FirebaseStorageandDatablockStoragedo NOT exactly match, but they are very close. The majority of differences are in the names methods we extracted, e.g.subscribeToKeyValuePairsvsgetKeyValuePairs.