Type error CdoTutorials can't be referred to - using JSON representation for caching#55231
Closed
vijayamanohararaj wants to merge 1 commit into
Closed
Type error CdoTutorials can't be referred to - using JSON representation for caching#55231vijayamanohararaj wants to merge 1 commit into
vijayamanohararaj wants to merge 1 commit into
Conversation
vijayamanohararaj
left a comment
Contributor
Author
There was a problem hiding this comment.
- - merge after the winter break, during first week of January 2024 to avoid any risk to HoC activities
- - Rebase with staging before merging
TurnerRiley
approved these changes
Dec 4, 2023
TurnerRiley
left a comment
Contributor
There was a problem hiding this comment.
Nice investigation! I'm not very familiar with our caching processes, but this makes sense to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: TypeError thrown upon first instance of deserializing contents from cache for tables that are populated dynamically through data from CSV files.
More details:
Fix: Serializing the data to a JSON blob before storing it in cache.
Previous attempt at fixing this issue #54703. This earlier attempt was based on an incorrect theory that the issue is happening only during first read from a thread that had not hydrated the cache. But, I hadn't see the call stack then, and missed that the deep copy was when the error was raised. Additionally, now from the call stack we see that this problem occurs for both read and write operations.
Warning!!
We have entered Pixel Lock for Hour of Code!
Computer Science Education Week will be happening from Dec 4 - Dec 10. Alongside this event, we will
be launching our new Hour of Code activity. Please consider any risk introduced in this PR that
could affect Dance Lab, instructions, saving and logging student progress, caching, or anything
related to the Hour of Code activities, old or new. Even small changes, such as a different button
color, are considered significant during this time. If this change will affect the new Hour of Code
activity in any way, join the morning change review to get your changes approved prior to merging.
Reach out to the Student Labs team for more details!
Links
https://codedotorg.atlassian.net/browse/ACQ-918?atlOrigin=eyJpIjoiMWM3ZTUwZWQwYWMyNDIzNjk5ZjA5ZTNlMTBhNDQwNWMiLCJwIjoiaiJ9
Testing story
Validated the change by hitting the endpoint locally, which exercises this code path. http://localhost:3000/api/hour/begin_mc.png
Deployment strategy
Given this might be a risky change around HoC timeframe, I plan to keep the PR open and merge during the first week of January 2024.
Follow-up work
Validate that the errors are dropping after the change gets deployed. Will use the same JIRA ticket to track.
Privacy
N/A
Security
N/A
Caching
PR Checklist: