Show learn more button catalog mobile#55161
Merged
Merged
Conversation
…de-dot-org/code-dot-org into show-learn-more-button-catalog-mobile
…precation Warning As a short-term fix to stop spamming Honeybadger. In the longer term, we plan to stop using this deprecated feature in favor of other methods for automatically restoring connections.
* add download video string * replace download icon with text link with icon
* add grades string * add wrapper element to sections * update theme and remove unneeded stylesheets
…locks (#55275) * add support for plus minus blocks * refactor to add helpers * use cdo locale * move installJoinBlock logic to customBlocks * settable minimum for input count * convert block attr to mutation * update licenses * customize mutator * include text_join blocks * forgot not operator * keep attribute * only attempt to add quotes with zero inputs (missing field warning) * code review
* DCDO control of announcements.json * DCDO control of announcements.json * DCDO control of announcements.json * DCDO control of announcements.json * Added tests for DCDO flag in announcements * empty commit message * Add tests for announcements false dcdo flag
| } | ||
|
|
||
| .learnMoreButton { | ||
| display: block !important; |
Contributor
There was a problem hiding this comment.
why are the !important tags necessary? What's overriding these styles?
Contributor
Author
There was a problem hiding this comment.
For the learn more button, there is Button styling that makes the display: inline block which displays the Learn More button at all times. The !important overrides this display.
Contributor
There was a problem hiding this comment.
Sorry for dragging this out but can you add a comment explaining that? !important tags are a huge anti-pattern so it's good to document why they're needed when they are.
* Add question to ImplementationPlan * Fix tests for new field * Use will_teach field in auto score * Uncomment out email send * Select will teach before selecting grades * Populate will_teach when creating a fake application * Only show warning after user has selected an option for willTeach * Fix another UI test * Addressing PR feedback
* Update cdoXml.js * Update cdoBlockSerializer.js
* cleaning up controller and test to reflect address changes * fixing order of operations * moving comment * removing other params for tests * fixing test
* UI and unit tests of hamburger menu * Specify which tests should be run on mobile * Hamburger UI tests * Updates to hamburger eyes tests * Hamburger UI test changes * Mobile tests for hamburger * Eyes test for mobile hamburger * Update Eyes test hamburger mobile * Eyes test changes hamburger * Hamburger UI Tests * Eyes test for Hamburger nav * UI tests hamburger nav
Add Marketing_ReadOnly role
* check for def block drag * refactor * Delete sl_level_0419.level * rename from updateEnabled * prevent undefined error
…Currculum Catalog (#55245) * Hide assign button for students on Currculum Catalog * Update UI tests for catalog card and expanded card * Unit tests for assign button student removed * Required props for Catalog Card unit tests * Update curriculum_catalog_card.module.scss * Add props for story * Add props for catalog unit tests * UI tests for hiding assign button for students * Remove unnecessary line in UI tests * Hide professional Learning section for students * Update teacher UI test catalog
* modified attempted_at to pull timestamp from S3 * removed UI test block * rubrics_controllers fixes and tests
940361f to
dec5b55
Compare
bethanyaconnor
approved these changes
Dec 12, 2023
bethanyaconnor
left a comment
Contributor
There was a problem hiding this comment.
One request for a comment but otherwise looks good to me!
…de-dot-org/code-dot-org into show-learn-more-button-catalog-mobile
juanmanzojr
added a commit
that referenced
this pull request
Dec 15, 2023
This reverts commit 6ba51f3.
juanmanzojr
added a commit
that referenced
this pull request
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Mobile, if the Expanded Card cannot fit the width of the screen, the Quick View button turns back into its original Learn More button.
Learn More button visible when Two curriculum Catalog Cards in a row
Learn More button visible with one Catalog Card per row
Quick View when the Expanded Card can fit the width of the screen
Links
Testing story
New UI tests within
dashboard/test/ui/features/acquisition_products/curriculum_catalog.featureDeployment strategy
Follow-up work
Hide the Related Curricula section when there are two Catalog Cards per row in order to fit the Expanded Card.
PR Checklist: