Skip to content

hoc2023: fix code flip#55145

Merged
breville merged 1 commit into
stagingfrom
hoc2023-fix-code-flip
Nov 27, 2023
Merged

hoc2023: fix code flip#55145
breville merged 1 commit into
stagingfrom
hoc2023-fix-code-flip

Conversation

@breville

Copy link
Copy Markdown
Member

This fixes two issues that could be seen when flipping to view code:

  • on macOS and iOS Safari 17, and also macOS Firefox 115 and 120, the visualization wasn't properly hidden despite the front having backface-visibillity: hidden. From a couple of online threads, it sounded like applying transform: translateZ(0) to that face might assist, and indeed it seems to work. I don't know the underlying reason why this works, though it seems possible this sends the rendering through an alternative code path or pipeline. We should keep an eye out for any side effects or additional incompatibilities; an alternative/additional solution could involve hiding the visualization partway through the flip animation.
  • the code preview was limited to 280px wide, but sometimes code blocks were wider. It can now go to 540px wide, making use of the full modal.

Before (macOS Safari 17)

dance-ai-flip-bug.mov

@breville breville requested review from a team and samantha-code November 26, 2023 04:17
@breville breville merged commit 18310a8 into staging Nov 27, 2023
@breville breville deleted the hoc2023-fix-code-flip branch November 27, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants