Skip to content

[Google Blockly] Add missing translations for functions and behaviors#55100

Merged
molly-moen merged 1 commit into
stagingfrom
molly/translatable-function-name
Nov 22, 2023
Merged

[Google Blockly] Add missing translations for functions and behaviors#55100
molly-moen merged 1 commit into
stagingfrom
molly/translatable-function-name

Conversation

@molly-moen

Copy link
Copy Markdown
Contributor

Warning!!

We have entered Pixel Lock for Hour of Code!

Computer Science Education Week will be happening from Dec 4 - Dec 10. Alongside this event, we will
be launching our new Hour of Code activity. Please consider any risk introduced in this PR that
could affect Dance Lab, instructions, saving and logging student progress, caching, or anything
related to the Hour of Code activities, old or new. Even small changes, such as a different button
color, are considered significant during this time. If this change will affect the new Hour of Code
activity in any way, join the morning change review to get your changes approved prior to merging.
Reach out to the Student Labs team for more details!

We were missing translations on the default function name ("do something") and "with" in with: this sprite that appears in the header of a behavior definition. This PR adds those missing translations. This should have no impact on Dance Lab, as this functionality is not used in Dance Lab.

Links

Testing story

Tested locally, the strings still appear in English as expected (we would need translations to make their way through the pipeline in order to see it work in other languages).

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team November 21, 2023 21:09
@molly-moen molly-moen requested a review from a team as a code owner November 21, 2023 21:10

@Erin007 Erin007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@molly-moen molly-moen merged commit 05a9db0 into staging Nov 22, 2023
@molly-moen molly-moen deleted the molly/translatable-function-name branch November 22, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants