hoc2015: show narrator image in error dialogs in levels 1-6 again.#5501
Merged
Conversation
Contributor
|
I'm not sure I understand this change in isolation. What I think I'm seeing is that |
Member
Author
|
Yes, in the previously-mentioned change, hideIconInClearPuzzle was overloaded to also hide the win & lose avatars in the result dialog, but we can do that more specifically as this change does. We still want a way for a skin to hide the icon in the clear puzzle dialog in particular, so I think it's reasonable to keep that flag in the skin for this specific purpose. |
Contributor
|
LGTM (sorry for the delay) |
breville
added a commit
that referenced
this pull request
Nov 20, 2015
hoc2015: show narrator image in error dialogs in levels 1-6 again.
deploy-code-org
added a commit
that referenced
this pull request
Nov 20, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5004 hid the narrator image from slightly more dialogs than needed.. it turns out that we can still show the narrator for error dialogs in levels 1-6 since those all have quoted messages, in the narrator's voice, to the student.