LTI teacher email input support#54972
Merged
Merged
Conversation
f52e4f5 to
cedaca9
Compare
daynew
commented
Dec 7, 2023
Comment on lines
+13
to
+23
| # user.authentication_options is a nested attribute we expose on the form | ||
| # for creating new user accounts. This code looks for new authentication | ||
| # option values submitted by the user, such as email, and updates the User | ||
| # object. | ||
| # Since a User can have multiple AuthenticationOptions, the form code treats | ||
| # the nested attribute as an Array, however there should only every be one | ||
| # value when a new account is being created. Since the User and | ||
| # AuthenticationOptions haven't actually been created in the DB yet, there is | ||
| # no unique `id` attribute for the objects, so we will assume the index in the | ||
| # array is consistent between the `user.authentication_options` and form | ||
| # `params`. |
Member
Author
There was a problem hiding this comment.
Let me know if this makes sense or if it is unnecessary.
Contributor
There was a problem hiding this comment.
I think we should keep the comment. Without it, the reasoning for these functions is pretty obscure.
carl-codeorg
approved these changes
Dec 7, 2023
carl-codeorg
left a comment
Contributor
There was a problem hiding this comment.
One typo on a comment, otherwise LGTM!
| # option values submitted by the user, such as email, and updates the User | ||
| # object. | ||
| # Since a User can have multiple AuthenticationOptions, the form code treats | ||
| # the nested attribute as an Array, however there should only every be one |
Contributor
There was a problem hiding this comment.
Minor typo: every should be ever
Comment on lines
+13
to
+23
| # user.authentication_options is a nested attribute we expose on the form | ||
| # for creating new user accounts. This code looks for new authentication | ||
| # option values submitted by the user, such as email, and updates the User | ||
| # object. | ||
| # Since a User can have multiple AuthenticationOptions, the form code treats | ||
| # the nested attribute as an Array, however there should only every be one | ||
| # value when a new account is being created. Since the User and | ||
| # AuthenticationOptions haven't actually been created in the DB yet, there is | ||
| # no unique `id` attribute for the objects, so we will assume the index in the | ||
| # array is consistent between the `user.authentication_options` and form | ||
| # `params`. |
Contributor
There was a problem hiding this comment.
I think we should keep the comment. Without it, the reasoning for these functions is pretty obscure.
…eacher-email-input
cedaca9 to
f607363
Compare
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
…-input LTI teacher email input support
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LTI doesn't guarantee to provide an Email when a teacher is signing up for a Code.org account. However, at Code.org, we want every Teacher account to have an email associated with it so we can reach out to them or find their User data if there are issues.
This PR adds an email input field to the account signup page if the LMS doesn't provide an email address and the user is a Teacher.
Links
Testing story