[Blockly] Reenable blocklayout UI tests#53645
Merged
Merged
Conversation
d890590 to
5e0c4d5
Compare
cat5inthecradle
left a comment
Contributor
There was a problem hiding this comment.
I see the edits, but I'm missing where this re-enables the tests
Contributor
Author
|
Good call @cat5inthecradle. Something is funky with the git diff. The re-enabling is the removal of the |
5e0c4d5 to
b78e72c
Compare
Contributor
Author
|
Fixed! |
fisher-alice
approved these changes
Sep 7, 2023
cat5inthecradle
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we merged #53154, some iPad and iPhone UI tests failed, so we turned them off temporarily by running the tests in Chrome only (see #53627). This PR updates the assertions and reenables the tests for all browsers. I confirmed the tests should pass by running them via a SauceLabs tunnel locally.
Links
See: https://codedotorg.atlassian.net/browse/CT-19
Testing story
Confirmed UI tests pass locally in all browsers.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: