render using lab2 framework#52730
Merged
ebeastlake merged 1 commit intoJul 11, 2023
Merged
Conversation
ebeastlake
added a commit
that referenced
this pull request
Jul 20, 2023
* add chat to allthethings * convert to aichat * add level to allthethings locally * inherit from level * fix misnamed variables * support non blockly puzzle options * add default i18n file * modify levels-aichat-main * render using lab2 framework (#52730) * remove unnecessary UI and LevelData for now; remove unneeded console statements * update comments * remove unnecessary boilerplate * delete more unnecessary files * add missing level file * update to use LabViewsRenderer * add to types_without_ideal_level_source * add aichat to edit.html.haml * add log messages for debugging * simplify fields .html.haml file to pass unit test * fix path to aichat_fields haml file * remove log messages * remove more log messages * remove unnecessary white space * modify test level to match row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beginning of incorporating learnings from #52454 (comment) into the initial chat levels.