Init navigation controller outside of inject#52588
Merged
Merged
Conversation
mikeharv
approved these changes
Jul 3, 2023
breville
reviewed
Jul 4, 2023
Comment on lines
+335
to
+336
| // Initialize plugin. | ||
| blocklyWrapper.navigationController.init(); |
Member
There was a problem hiding this comment.
Maybe worth a comment that this means it's called once per page load, while inject can now potentially be called more than once?
Though I'm not actually sure whether folks arriving at this code in the future will wonder...
Contributor
Author
There was a problem hiding this comment.
Hmm yeah I can update this comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
navigationController.init()call to the to top levelinitializeBlocklyWrapper()function, and out ofinject(). This allowsinject()to be called multiple times, as previously callinginject()more than once would throw an error due to the navigation controller already being initialized.Links
Slack discussion: https://codedotorg.slack.com/archives/C04TH8400AU/p1688066270812829
Testing story
Tested locally on a Google Blockly level (Dance Party)