Show PL Program Info Page even without Programs Offered#49586
Conversation
|
Hmm, interesting. Any idea why this wasn't coming up in our pipeline? Do you know if it's something that's been flagged? Would love for this to be on people's radar –– could you maybe ping infra about it? It looks like it's fairly new syntax, but I'm concerned that it's not being caught in our Drone runs, or, better, locally. |
|
Okay it looks like we're running 14.17.1 of node https://github.com/code-dot-org/code-dot-org/blob/staging/.nvmrc but we need at least 16.6.0 for the |
Good point! It did get flagged in the apps tests in this thread. The |
Revert fix
This is a recreation of this PR which was reverted due to
.at()not being recognized as a function in the testing. I switched it to just use array square brackets to refer to that index's value to remove references to.at().PR info
A bug on the Professional Learning Program Information page was discovered where no information was being shown for regional partners not offering a program at that time (which was throwing an error in console). It's a bug from this PR where it would try to load the workshop cards but not find any programs offered.
This PR just adds a check to make sure there are programs before trying to render cards for them. If there are no programs offered, it will just show the rest of the information without the workshop cards.
Bug behavior for no programs offered
With fix behavior for no programs offered
Links
Slack thread this was brought up: here
Testing story
Local testing.
PR Checklist: