Skip to content

IA Play Lab - V1#4919

Merged
caleybrock merged 10 commits into
stagingfrom
ia-round2
Oct 29, 2015
Merged

IA Play Lab - V1#4919
caleybrock merged 10 commits into
stagingfrom
ia-round2

Conversation

@caleybrock

Copy link
Copy Markdown
Contributor
  • new levels, base on original play lab.
  • new assets
  • new strings
  • gets new sprite sizes working with 'extraEmotions'
  • TODO: make emotions animations work

fyi, since I'm editing studio.js - @islemaster @breville @cpirich

@breville please review :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these placeholder names?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, along with the placeholder images

@breville

Copy link
Copy Markdown
Member

lgtm.

Comment thread apps/src/studio/skins.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call making extraEmotions an integer and putting it here in the skin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

caleybrock added a commit that referenced this pull request Oct 29, 2015
@caleybrock caleybrock merged commit debbe71 into staging Oct 29, 2015
deploy-code-org added a commit that referenced this pull request Oct 29, 2015
debbe71 Merge pull request #4919 from code-dot-org/ia-round2 (Caley Brock)
22108b6 Automatically built. (Continuous Integration)
224dc67 Merge pull request #4786 from code-dot-org/pulse-item (Brad Buchanan)
34e9f9e Merge branch 'staging' into ia-round2 (caleybrock)
d619792 Automatically built. (Continuous Integration)
8403a32 Merge pull request #4920 from code-dot-org/testfixes (Elijah Hamovitz)
0ff348c Temporarily removing funOMeter test (Elijah Hamovitz)
b457e24 Merge pull request #4916 from code-dot-org/ie10tests (Bjvanminnen)
5b89e35 more IE10 (Brent Van Minnen)
1876a7f o Merge branch 'staging' of github.com:code-dot-org/code-dot-org into staging (Trevor Berg)
541fdc5 Fix issues with JSONFileDataAdapter (Trevor Berg)
@caleybrock caleybrock deleted the ia-round2 branch October 29, 2015 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants