Skip to content

Always expect a channel in project.js#4822

Merged
joshlory merged 2 commits into
stagingfrom
project-expect-channel
Oct 26, 2015
Merged

Always expect a channel in project.js#4822
joshlory merged 2 commits into
stagingfrom
project-expect-channel

Conversation

@joshlory

@joshlory joshlory commented Oct 26, 2015

Copy link
Copy Markdown
Contributor

Calling dashboard.project.save used to create a new project if a channel didn't already exist. Now that the server always provides the channel this logic is no longer needed.

@davidsbailey

davidsbailey commented Oct 26, 2015

Copy link
Copy Markdown
Member

LGTM

This code change looks good. It looks like there's also an if (channelId) in delete which can go away too. Might be worth fixing now while we're thinking about it. Later is fine too.

@joshlory

joshlory commented Oct 26, 2015

Copy link
Copy Markdown
Contributor Author

Good catch, fixed in 7104817.

joshlory pushed a commit that referenced this pull request Oct 26, 2015
Merge pull request #4822 from code-dot-org/project-expect-channel
02ac2f6 
Always expect a channel in `project.js`
@joshlory joshlory merged commit 02ac2f6 into staging Oct 26, 2015
@joshlory joshlory deleted the project-expect-channel branch October 26, 2015 23:01
deploy-code-org added a commit that referenced this pull request Oct 26, 2015
@deploy-code-org
Automatically built.
aba2008 
02ac2f6 Merge pull request #4822 from code-dot-org/project-expect-channel (Josh Lory)
61b8006 Merge pull request #4824 from code-dot-org/create-confirmed-test-users (Laurel)
1ab6dff Automatically built. (Continuous Integration)
This was referenced Oct 28, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidsbailey davidsbailey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshlory @davidsbailey