add admin_required to Script DSL#4811
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Can you use generate_admin_only_tests_for in dashboard/test/test_helper.rb?
Contributor
Author
There was a problem hiding this comment.
not as written because I need to create a script. I could maybe change the generate_admin_only_tests_for to yield to a block instead of take params so I could have both the get and the create in there
Member
There was a problem hiding this comment.
our .script files usually have true in single quotes.. does it matter?
Contributor
Author
There was a problem hiding this comment.
ha, it's supposed to be a string, it coincidentally works for boolean true also. I will add another test so we have a test with both.
Member
|
lgtm |
laurelfan
added a commit
that referenced
this pull request
Oct 26, 2015
add admin_required to Script DSL
deploy-code-org
added a commit
that referenced
this pull request
Oct 26, 2015
0578c5c Merge pull request #4742 from code-dot-org/configCleanup (Bjvanminnen) 75af0cc Merge pull request #4815 from code-dot-org/levelbuilder (Laurel) dfe9ba3 Merge pull request #4814 from code-dot-org/fix-applab-most-recent (Josh Lory) ff5f925 content changes (-laurel) (Continuous Integration) e3cd8cf When logging in, auth before `most_recent` to get the correct project (Josh Lory) 8083ad5 Merge pull request #4813 from code-dot-org/staging (Laurel) b5fa69b Merge pull request #4811 from code-dot-org/script-admin_required2 (Laurel)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.