Use require_relative to load cookbooks#4802
Merged
Merged
Conversation
Contributor
|
LGTM, thanks for catching and fixing this. |
philbogle
added a commit
that referenced
this pull request
Oct 25, 2015
Use require_relative to load cookbooks
deploy-code-org
added a commit
that referenced
this pull request
Oct 26, 2015
a2c918c Merge pull request #4804 from code-dot-org/no_request_forgery (philbogle) 711da5b Merge commit 'a1a312f' into no_request_forgery (Phil Bogle) cddfa8e Merge pull request #4802 from code-dot-org/require_relative (philbogle) a1a312f Increase app JS test timeout to reduce flakes (Phil Bogle) 4aae596 Automatically built. (Continuous Integration) f2e49e9 Merge pull request #4806 from code-dot-org/hoc2015newsounds (Brendan Reville)
Contributor
Author
|
I am rolling back my change because when I try to run UI tests, Pegasus complains: I think this is a known bug in ruby; e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use require_relative for loading the http_cache library so that the require will succeed regardless of the current working directory.
(The current require statement for loading cookbooks only works when the current working directory is dashboard and doesn't work when I run from test/ui.)