Draw Anna/Elsa circles more nicely by turning during same frame as forward move#478
Merged
Conversation
Member
Author
|
@Bjvanminnen how does this look? |
Contributor
There was a problem hiding this comment.
open brace should be at end of line above instead of getting its own line
Contributor
There was a problem hiding this comment.
Wonder if we can come up with a more clear name. Maybe checkForMoveAndTurn? Also seems a little strange that we pass it the first tuple, but then use api.log for the subsequent tuple. Seems like we should either pass it both, or use api.log for both.
Member
Author
|
@Bjvanminnen awesome feedback, think i've addressed it all.. |
Contributor
There was a problem hiding this comment.
remove command/values from parameters as we're not using them now
Contributor
There was a problem hiding this comment.
unused, right? otherwise everything LGTM :)
breville
added a commit
that referenced
this pull request
Nov 20, 2014
Draw Anna/Elsa circles more nicely by turning during same frame as forward move
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.