Skip to content

Change to reporting the answer text rather than the answer index (per request).#4775

Merged
ashercodeorg merged 7 commits into
stagingfrom
convertNumsToAnswers
Oct 23, 2015
Merged

Change to reporting the answer text rather than the answer index (per request).#4775
ashercodeorg merged 7 commits into
stagingfrom
convertNumsToAnswers

Conversation

@ashercodeorg

Copy link
Copy Markdown
Contributor

Note that the screenshot portrays local data (lack of responses and different level numbers).

screenshot

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/TrailingWhitespace: Trailing whitespace detected.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would Level.where(id: level_id).first.pluck(:properties) work here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Hamms

Hamms commented Oct 23, 2015

Copy link
Copy Markdown
Contributor

It would be nice to see a few more careful checks; making sure that level_answers[response[2].to_i] is actually a hash, making sure that there actually exists some Level.where(id: level_id), etc, but otherwise LGTM

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/TrailingWhitespace: Trailing whitespace detected.

ashercodeorg added a commit that referenced this pull request Oct 23, 2015
Change to reporting the answer text rather than the answer index (per request).
@ashercodeorg ashercodeorg merged commit 771c639 into staging Oct 23, 2015
@ashercodeorg ashercodeorg deleted the convertNumsToAnswers branch October 23, 2015 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants