Session to client migrations#4412
Merged
philbogle merged 1 commit intoOct 8, 2015
Merged
Conversation
Contributor
|
LGTM |
Contributor
Author
|
I confirmed that the timeout in the CircleCI is a known flaky test and not related to this PR. For example, this is another such failure: |
philbogle
added a commit
that referenced
this pull request
Oct 8, 2015
…ssion_to_client_migrations Session to client migrations
Contributor
Author
|
This is still encountering some issues with the CDN as seen via staging, so unfortunately I'm going to have to revert it again. Adhoc also has the CDN set up so I can look there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate videos_seen, callouts_seen, and scripts from the session cookie to unencrypted cookies accessible from Javascript.
(I rolled back the original version of this PR (#4299) because the needed cookbook changes had not been applied yet. This time around those changes have been deployed all the way to production so I hope to see no further difficulties.)
Reverts #4299 which reverted #4283.