Revert "Revert "Whitelist cookies in development""#4359
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
The flow here might be clear if this was written as a case statement.
Contributor
Author
|
Looks good, one code structure nit and some missing escaping (I believe). |
wjordan
added a commit
that referenced
this pull request
Oct 8, 2015
…okie_whitelist Revert "Revert "Whitelist cookies in development""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores #4341 (which I inadvertantly merged)
Follow-on to #4207
.
This PR adds a CookieWhitelist Rack middleware that whitelists cookies based on the path-based cache behaviors defined in http-cache configuration used by CloudFront/Varnish.
This will allow our development environment to approximate the cookie-whitelisting action provided by our HTTP cache layer (improving our dev-prod parity and helping avoid environment-difference issues in development), without adding additional infrastructure dependencies to our development setup.