Checks whether header is nil before looking up the litmus_tracking_id_key. by ashercodeorg · Pull Request #4303 · code-dot-org/code-dot-org

ashercodeorg · 2015-10-02T01:37:20Z

The intent is to eliminate the plethora of error messages being seen in the Staging Room.

ashercodeorg · 2015-10-02T01:38:38Z

Lacking context, I'm doing the simplest thing that seems sensical. Please check carefully that the simple fix is a reasonable solution.

aoby · 2015-10-02T17:13:50Z

This will certainly fix the error, but I don't have enough context to know if nil tracking_id is an acceptable state downstream. @laurelfan how does this look?

philbogle · 2015-10-02T18:22:51Z

This is an OK short term band-aid but we definitely need to fix the root cause and then remove this code which suppressing warning about a potentially bad condition.

Without the litmus tracking, we will lose visibility as to whether a user has opened an email, so it would be bad if this started happening at a high rate and we didn't know about it!

This code runs in a cron job so it's not trivial to have it warn even N message, perhaps we could do something probablilistic (warning 1% of the time say).

philbogle · 2015-10-02T18:40:03Z

Laurel mentioned a better way, we can handle the missing data gracefully and log the bad condition via honeybadger. (They have an API which we can call to report the issue and they'll aggregate and send an email.)

… key. The intent is to eliminate the plethora of error messages being seen in the Staging Room.

… tracking ID.

…into fixPosteErrors

ashercodeorg · 2015-10-02T19:21:00Z

Added TODO. Feel welcome to take another look.

philbogle · 2015-10-02T19:27:19Z

LGTM. There is a tracking bug which you can reference in the TODO.
https://www.pivotaltracker.com/story/show/104750788

ashercodeorg · 2015-10-02T19:34:38Z

Done (phil).

Checks whether header is nil before looking up the litmus_tracking_id_key.

philbogle · 2015-10-02T19:36:43Z

Thanks for jumping on this Asher.

code-org · 2015-10-02T19:39:22Z

was there any investigation of the root cause?

laurelfan · 2015-10-02T19:45:51Z

(code-org was me)

philbogle · 2015-10-02T20:00:54Z

Yes, Andrew is investigating, the tracking bug for the root cause
investigation is https://www.pivotaltracker.com/story/show/104756402

Separately, there are tracking bugs in HOC for logging to hipchat on
unhandled exceptions and on missing litmus_tracking_id headers so we have
good visibility into errors without spamming.

On Fri, Oct 2, 2015 at 12:39 PM, code.org notifications@github.com wrote:

was there any investigation of the root cause?

—
Reply to this email directly or view it on GitHub
#4303 (comment)
.

aoby · 2015-10-02T20:06:34Z

This fix just bumped the error upstream. From staging logs:
/home/ubuntu/staging/bin/deliver_poste_messages:126:in send': undefined method[]' for nil:NilClass (NoMethodError)

Root cause is ~/staging/pegasus/emails/10-5-latam-hoc.md had no header on staging. Laura added the file yesterday, and is fixing it now...

philbogle · 2015-10-02T20:08:35Z

Would it make sense to add a presubmit script that verifies the emails are
well-formed before allowing them to be checked in?

On Fri, Oct 2, 2015 at 1:06 PM, Andrew Oberhardt notifications@github.com
wrote:

This fix just bumped the error upstream. From staging logs:
/home/ubuntu/staging/bin/deliver_poste_messages:126:in send': undefined
method[]' for nil:NilClass (NoMethodError)

Root cause is ~/staging/pegasus/emails/10-5-latam-hoc.md had no header on
staging. Laura added the file yesterday, and is fixing it now...

—
Reply to this email directly or view it on GitHub
#4303 (comment)
.

laurelfan · 2015-10-02T20:15:05Z

That makes sense. A better pipeline for getting errors to the content authors would help too.

If we are going to switch to having content authors type/paste emails directly in production (which is #1 on Andrew's feature list) it may not be worth doing this work though.

On Oct 2, 2015, at 13:08, philbogle notifications@github.com wrote:

Would it make sense to add a presubmit script that verifies the emails are
well-formed before allowing them to be checked in?

On Fri, Oct 2, 2015 at 1:06 PM, Andrew Oberhardt notifications@github.com
wrote:

This fix just bumped the error upstream. From staging logs:
/home/ubuntu/staging/bin/deliver_poste_messages:126:in send': undefined
method[]' for nil:NilClass (NoMethodError)

Root cause is ~/staging/pegasus/emails/10-5-latam-hoc.md had no header on
staging. Laura added the file yesterday, and is fixing it now...

—
Reply to this email directly or view it on GitHub
#4303 (comment)
.

—
Reply to this email directly or view it on GitHub.

philbogle · 2015-10-02T20:27:46Z

I think we would much of the same validation logic even when they submit
via a web form (assuming there are possibly invalid headers is authored by
content providers), so worthwhile building the library that does the
validation. Then it will hopefully be easy to call either from a presubmit
hook or from the web controller.

On Fri, Oct 2, 2015 at 1:15 PM, Laurel notifications@github.com wrote:

That makes sense. A better pipeline for getting errors to the content
authors would help too.

If we are going to switch to having content authors type/paste emails
directly in production (which is #1 on Andrew's feature list) it may not be
worth doing this work though.

On Oct 2, 2015, at 13:08, philbogle notifications@github.com wrote:

Would it make sense to add a presubmit script that verifies the emails
are
well-formed before allowing them to be checked in?

On Fri, Oct 2, 2015 at 1:06 PM, Andrew Oberhardt <
notifications@github.com>
wrote:

This fix just bumped the error upstream. From staging logs:
/home/ubuntu/staging/bin/deliver_poste_messages:126:in send': undefined
method[]' for nil:NilClass (NoMethodError)

Root cause is ~/staging/pegasus/emails/10-5-latam-hoc.md had no
header on
staging. Laura added the file yesterday, and is fixing it now...

—
Reply to this email directly or view it on GitHub
<
#4303 (comment)

.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#4303 (comment)
.

commit 85041b3 Merge: 7376e38 6d2c4c4 Author: Brad Buchanan <bradley.c.buchanan@gmail.com> Date: Fri Oct 2 13:39:28 2015 -0700 Merge pull request #4184 from code-dot-org/applab-google-charts Applab: Google charts integration commit 7376e38 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:38:32 2015 +0000 dropbox and gsheet changes commit f97e84c Merge: 5da36f9 a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:11 2015 -0700 Merge pull request #4315 from code-dot-org/revert-4309-companies Revert "Change orgs to companies" commit a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:01 2015 -0700 Revert "Change orgs to companies" commit 5da36f9 Merge: d9f3f9b 7cd8a05 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:29:16 2015 -0700 Merge pull request #4309 from code-dot-org/companies Change orgs to companies commit d9f3f9b Merge: 06a424d 337c614 Author: Josh Lory <josh.lory@code.org> Date: Fri Oct 2 13:20:11 2015 -0700 Merge pull request #4298 from code-dot-org/fix-rubocop-parser-warnings Fix rubocop parser warnings commit 06a424d Merge: 6cf948f ef90eed Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:08:29 2015 -0700 Merge pull request #4314 from code-dot-org/eslint get lint in dashboard passing again commit ef90eed Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:52:16 2015 -0700 get lint in dashboard passing again commit 6cf948f Merge: 077e25f 351d29b Author: ashercodeorg <asher@code.org> Date: Fri Oct 2 14:35:29 2015 -0500 Merge pull request #4303 from code-dot-org/fixPosteErrors Checks whether header is nil before looking up the litmus_tracking_id_key. commit 351d29b Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:34:06 2015 -0500 Adds the tracking bug URL to the TODO(andrew) in deliver_poste_messages. commit 077e25f Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:27:14 2015 -0700 disable dashboard linting until fixed commit 1061e95 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:12:10 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit 2db4d53 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:08:07 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit f948c38 Merge: 7822c7f d815b63 Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:07:32 2015 -0500 Merge branch 'staging' of https://github.com/code-dot-org/code-dot-org into fixPosteErrors commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 7822c7f Author: Asher Kach <asher@code.org> Date: Fri Oct 2 13:54:14 2015 -0500 Adds a TODO(andrew) to surface a signal how often we are not seeing a tracking ID. commit dd3472f Author: Asher Kach <asher@code.org> Date: Thu Oct 1 20:36:17 2015 -0500 Checks whether header is nil before looking up the litmus_tracking_id key. The intent is to eliminate the plethora of error messages being seen in the Staging Room. commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 7cd8a05 Author: caleybrock <caleybrock7@gmail.com> Date: Fri Oct 2 11:23:11 2015 -0700 change title commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings

commit d08b2ca Merge: 6a6abde 2ebef3a Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:40:36 2015 -0700 Merge pull request #4297 from code-dot-org/oneReact [Finishes #102389490] single react commit 6a6abde Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:40:07 2015 +0000 Automatically built. commit 85041b3 Merge: 7376e38 6d2c4c4 Author: Brad Buchanan <bradley.c.buchanan@gmail.com> Date: Fri Oct 2 13:39:28 2015 -0700 Merge pull request #4184 from code-dot-org/applab-google-charts Applab: Google charts integration commit 7376e38 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:38:32 2015 +0000 dropbox and gsheet changes commit f97e84c Merge: 5da36f9 a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:11 2015 -0700 Merge pull request #4315 from code-dot-org/revert-4309-companies Revert "Change orgs to companies" commit a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:01 2015 -0700 Revert "Change orgs to companies" commit 5da36f9 Merge: d9f3f9b 7cd8a05 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:29:16 2015 -0700 Merge pull request #4309 from code-dot-org/companies Change orgs to companies commit d9f3f9b Merge: 06a424d 337c614 Author: Josh Lory <josh.lory@code.org> Date: Fri Oct 2 13:20:11 2015 -0700 Merge pull request #4298 from code-dot-org/fix-rubocop-parser-warnings Fix rubocop parser warnings commit 06a424d Merge: 6cf948f ef90eed Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:08:29 2015 -0700 Merge pull request #4314 from code-dot-org/eslint get lint in dashboard passing again commit ef90eed Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:52:16 2015 -0700 get lint in dashboard passing again commit 6cf948f Merge: 077e25f 351d29b Author: ashercodeorg <asher@code.org> Date: Fri Oct 2 14:35:29 2015 -0500 Merge pull request #4303 from code-dot-org/fixPosteErrors Checks whether header is nil before looking up the litmus_tracking_id_key. commit 351d29b Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:34:06 2015 -0500 Adds the tracking bug URL to the TODO(andrew) in deliver_poste_messages. commit 077e25f Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:27:14 2015 -0700 disable dashboard linting until fixed commit 1061e95 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:12:10 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit 2db4d53 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:08:07 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit f948c38 Merge: 7822c7f d815b63 Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:07:32 2015 -0500 Merge branch 'staging' of https://github.com/code-dot-org/code-dot-org into fixPosteErrors commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 7822c7f Author: Asher Kach <asher@code.org> Date: Fri Oct 2 13:54:14 2015 -0500 Adds a TODO(andrew) to surface a signal how often we are not seeing a tracking ID. commit dd3472f Author: Asher Kach <asher@code.org> Date: Thu Oct 1 20:36:17 2015 -0500 Checks whether header is nil before looking up the litmus_tracking_id key. The intent is to eliminate the plethora of error messages being seen in the Staging Room. commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 7cd8a05 Author: caleybrock <caleybrock7@gmail.com> Date: Fri Oct 2 11:23:11 2015 -0700 change title commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings

commit 534bad3 Merge: b0cef5a e6e5220 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 14:31:28 2015 -0700 Merge pull request #4278 from code-dot-org/abusedAssets [Finishes #103047632] Block assets in abusive projects commit b0cef5a Merge: 5d00c24 f26dd55 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 14:06:56 2015 -0700 Merge pull request #4312 from code-dot-org/permissions Add teacher permissions to special events commit 5d00c24 Merge: 26ccaac 419c186 Author: Will Jordan <wjordan@users.noreply.github.com> Date: Fri Oct 2 14:04:55 2015 -0700 Merge pull request #4301 from code-dot-org/varnish_hostname Match (dashboard|studio).code.org hostnames to dashboard in Varnish config commit 26ccaac Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:54:05 2015 +0000 Automatically built. commit d08b2ca Merge: 6a6abde 2ebef3a Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:40:36 2015 -0700 Merge pull request #4297 from code-dot-org/oneReact [Finishes #102389490] single react commit 6a6abde Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:40:07 2015 +0000 Automatically built. commit 85041b3 Merge: 7376e38 6d2c4c4 Author: Brad Buchanan <bradley.c.buchanan@gmail.com> Date: Fri Oct 2 13:39:28 2015 -0700 Merge pull request #4184 from code-dot-org/applab-google-charts Applab: Google charts integration commit 7376e38 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:38:32 2015 +0000 dropbox and gsheet changes commit f97e84c Merge: 5da36f9 a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:11 2015 -0700 Merge pull request #4315 from code-dot-org/revert-4309-companies Revert "Change orgs to companies" commit a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:01 2015 -0700 Revert "Change orgs to companies" commit 5da36f9 Merge: d9f3f9b 7cd8a05 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:29:16 2015 -0700 Merge pull request #4309 from code-dot-org/companies Change orgs to companies commit d9f3f9b Merge: 06a424d 337c614 Author: Josh Lory <josh.lory@code.org> Date: Fri Oct 2 13:20:11 2015 -0700 Merge pull request #4298 from code-dot-org/fix-rubocop-parser-warnings Fix rubocop parser warnings commit 06a424d Merge: 6cf948f ef90eed Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:08:29 2015 -0700 Merge pull request #4314 from code-dot-org/eslint get lint in dashboard passing again commit ef90eed Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:52:16 2015 -0700 get lint in dashboard passing again commit 6cf948f Merge: 077e25f 351d29b Author: ashercodeorg <asher@code.org> Date: Fri Oct 2 14:35:29 2015 -0500 Merge pull request #4303 from code-dot-org/fixPosteErrors Checks whether header is nil before looking up the litmus_tracking_id_key. commit 351d29b Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:34:06 2015 -0500 Adds the tracking bug URL to the TODO(andrew) in deliver_poste_messages. commit 077e25f Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:27:14 2015 -0700 disable dashboard linting until fixed commit 1061e95 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:12:10 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit 2db4d53 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:08:07 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit f948c38 Merge: 7822c7f d815b63 Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:07:32 2015 -0500 Merge branch 'staging' of https://github.com/code-dot-org/code-dot-org into fixPosteErrors commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 7822c7f Author: Asher Kach <asher@code.org> Date: Fri Oct 2 13:54:14 2015 -0500 Adds a TODO(andrew) to surface a signal how often we are not seeing a tracking ID. commit dd3472f Author: Asher Kach <asher@code.org> Date: Thu Oct 1 20:36:17 2015 -0500 Checks whether header is nil before looking up the litmus_tracking_id key. The intent is to eliminate the plethora of error messages being seen in the Staging Room. commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 7cd8a05 Author: caleybrock <caleybrock7@gmail.com> Date: Fri Oct 2 11:23:11 2015 -0700 change title commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit d08b2ca Merge: 6a6abde 2ebef3a Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:40:36 2015 -0700 Merge pull request #4297 from code-dot-org/oneReact [Finishes #102389490] single react commit 6a6abde Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:40:07 2015 +0000 Automatically built. commit 85041b3 Merge: 7376e38 6d2c4c4 Author: Brad Buchanan <bradley.c.buchanan@gmail.com> Date: Fri Oct 2 13:39:28 2015 -0700 Merge pull request #4184 from code-dot-org/applab-google-charts Applab: Google charts integration commit 7376e38 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:38:32 2015 +0000 dropbox and gsheet changes commit f97e84c Merge: 5da36f9 a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:11 2015 -0700 Merge pull request #4315 from code-dot-org/revert-4309-companies Revert "Change orgs to companies" commit a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:01 2015 -0700 Revert "Change orgs to companies" commit 5da36f9 Merge: d9f3f9b 7cd8a05 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:29:16 2015 -0700 Merge pull request #4309 from code-dot-org/companies Change orgs to companies commit d9f3f9b Merge: 06a424d 337c614 Author: Josh Lory <josh.lory@code.org> Date: Fri Oct 2 13:20:11 2015 -0700 Merge pull request #4298 from code-dot-org/fix-rubocop-parser-warnings Fix rubocop parser warnings commit 06a424d Merge: 6cf948f ef90eed Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 13:08:29 2015 -0700 Merge pull request #4314 from code-dot-org/eslint get lint in dashboard passing again commit ef90eed Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:52:16 2015 -0700 get lint in dashboard passing again commit 6cf948f Merge: 077e25f 351d29b Author: ashercodeorg <asher@code.org> Date: Fri Oct 2 14:35:29 2015 -0500 Merge pull request #4303 from code-dot-org/fixPosteErrors Checks whether header is nil before looking up the litmus_tracking_id_key. commit 351d29b Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:34:06 2015 -0500 Adds the tracking bug URL to the TODO(andrew) in deliver_poste_messages. commit 077e25f Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 12:27:14 2015 -0700 disable dashboard linting until fixed commit 1061e95 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:12:10 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit 2db4d53 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 19:08:07 2015 +0000 Automatically built. commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 3db7565 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 10:57:46 2015 -0700 remove $ from global list at the top of a bunch of files commit ae5b9bb Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 17:01:53 2015 +0000 content changes -trevor commit 4f4e310 Merge: c459711 4ada13c Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:55:08 2015 -0700 Merge pull request #4307 from code-dot-org/levelbuilder Levelbuilder -> Staging commit 4ada13c Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:54:05 2015 +0000 levelbuilder changes -trevor commit 5c01e57 Merge: 3e96865 c459711 Author: Trevor Berg <trevor@code.org> Date: Fri Oct 2 09:48:52 2015 -0700 Merge pull request #4306 from code-dot-org/staging Levelbuilder -> Staging commit 3e96865 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 16:48:00 2015 +0000 levelbuilder changes -Trevor commit f948c38 Merge: 7822c7f d815b63 Author: Asher Kach <asher@code.org> Date: Fri Oct 2 14:07:32 2015 -0500 Merge branch 'staging' of https://github.com/code-dot-org/code-dot-org into fixPosteErrors commit d815b63 Merge: 9699e34 d49c7b9 Author: Bjvanminnen <Bjvanminnen@gmail.com> Date: Fri Oct 2 12:07:04 2015 -0700 Merge pull request #4288 from code-dot-org/eslint [Finishes #104348304] linting in dashboard commit 7822c7f Author: Asher Kach <asher@code.org> Date: Fri Oct 2 13:54:14 2015 -0500 Adds a TODO(andrew) to surface a signal how often we are not seeing a tracking ID. commit dd3472f Author: Asher Kach <asher@code.org> Date: Thu Oct 1 20:36:17 2015 -0500 Checks whether header is nil before looking up the litmus_tracking_id key. The intent is to eliminate the plethora of error messages being seen in the Staging Room. commit 9699e34 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:23:20 2015 +0000 Update the level used for auto open function editor eyes test. commit 7cd8a05 Author: caleybrock <caleybrock7@gmail.com> Date: Fri Oct 2 11:23:11 2015 -0700 change title commit 05877e4 Merge: ae5b9bb 03e36de Author: Brendan Reville <breville@users.noreply.github.com> Date: Fri Oct 2 11:21:15 2015 -0700 Merge pull request #4313 from code-dot-org/levelbuilder levelbuilder -> staging (one change) commit d49c7b9 Author: Brent Van Minnen <bjvanminnen@gmail.com> Date: Fri Oct 2 11:20:34 2015 -0700 lint all javascripts in dashboard/apps commit 03e36de Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 18:20:02 2015 +0000 Add level that auto opens function editor to /s/allthethings commit 85041b3 Merge: 7376e38 6d2c4c4 Author: Brad Buchanan <bradley.c.buchanan@gmail.com> Date: Fri Oct 2 13:39:28 2015 -0700 Merge pull request #4184 from code-dot-org/applab-google-charts Applab: Google charts integration commit 7376e38 Author: Continuous Integration <dev@code.org> Date: Fri Oct 2 20:38:32 2015 +0000 dropbox and gsheet changes commit f97e84c Merge: 5da36f9 a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:11 2015 -0700 Merge pull request #4315 from code-dot-org/revert-4309-companies Revert "Change orgs to companies" commit a2f7980 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:32:01 2015 -0700 Revert "Change orgs to companies" commit 5da36f9 Merge: d9f3f9b 7cd8a05 Author: Caley Brock <caleybrock7@gmail.com> Date: Fri Oct 2 13:29:16 2015 -0700 Merge pull request #4309 from code-dot-org/companies Change orgs to companies commit d9f3f9b Merge: 06a424d 337c614 Author: Josh Lory <josh.lory@code.org> Date: Fri Oct 2 13:20:11 2015 -0700 Merge pull request #4298 from code-dot-org/fix-rubocop-parser-warnings Fix rubocop parser warnings

laurelfan · 2015-10-02T22:10:57Z

Hopefully in that case it can be a lot easier because the validation
library can be the same as the renderer so we don't need to do the work of
figuring out how to call the renderer from a git hook script.

In this case instead of swallowing the error we should be doing something
like:

if headers == nil
raise "headers are required"
end

(where the exception is handled and shown to the user)

On Fri, Oct 2, 2015 at 1:27 PM, philbogle notifications@github.com wrote:

I think we would much of the same validation logic even when they submit
via a web form (assuming there are possibly invalid headers is authored by
content providers), so worthwhile building the library that does the
validation. Then it will hopefully be easy to call either from a presubmit
hook or from the web controller.

On Fri, Oct 2, 2015 at 1:15 PM, Laurel notifications@github.com wrote:

That makes sense. A better pipeline for getting errors to the content
authors would help too.

If we are going to switch to having content authors type/paste emails
directly in production (which is #1 on Andrew's feature list) it may not
be
worth doing this work though.

On Oct 2, 2015, at 13:08, philbogle notifications@github.com wrote:

Would it make sense to add a presubmit script that verifies the emails
are
well-formed before allowing them to be checked in?

On Fri, Oct 2, 2015 at 1:06 PM, Andrew Oberhardt <
notifications@github.com>
wrote:

This fix just bumped the error upstream. From staging logs:
/home/ubuntu/staging/bin/deliver_poste_messages:126:in send':
undefined
method[]' for nil:NilClass (NoMethodError)

Root cause is ~/staging/pegasus/emails/10-5-latam-hoc.md had no
header on
staging. Laura added the file yesterday, and is fixing it now...

—
Reply to this email directly or view it on GitHub
<

#4303 (comment)

.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
<
#4303 (comment)

.

—
Reply to this email directly or view it on GitHub
#4303 (comment)
.

ashercodeorg assigned laurelfan Oct 2, 2015

ashercodeorg added 3 commits October 2, 2015 13:58

Checks whether header is nil before looking up the litmus_tracking_id…

dd3472f

… key. The intent is to eliminate the plethora of error messages being seen in the Staging Room.

Adds a TODO(andrew) to surface a signal how often we are not seeing a…

7822c7f

… tracking ID.

Merge branch 'staging' of https://github.com/code-dot-org/code-dot-org …

f948c38

…into fixPosteErrors

ashercodeorg force-pushed the fixPosteErrors branch from 98d8c10 to f948c38 Compare October 2, 2015 19:16

Adds the tracking bug URL to the TODO(andrew) in deliver_poste_messages.

351d29b

ashercodeorg added a commit that referenced this pull request Oct 2, 2015

Merge pull request #4303 from code-dot-org/fixPosteErrors

6cf948f

Checks whether header is nil before looking up the litmus_tracking_id_key.

ashercodeorg merged commit 6cf948f into staging Oct 2, 2015

ashercodeorg deleted the fixPosteErrors branch October 2, 2015 19:35

Uh oh!

Conversation

ashercodeorg commented Oct 2, 2015

Uh oh!

ashercodeorg commented Oct 2, 2015

Uh oh!

aoby commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

ashercodeorg commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

ashercodeorg commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

code-org commented Oct 2, 2015

Uh oh!

laurelfan commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

aoby commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

laurelfan commented Oct 2, 2015

Uh oh!

philbogle commented Oct 2, 2015

Uh oh!

laurelfan commented Oct 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants