Skip to content

[Finishes #101465756, #101453700] Chrome-less share for App Lab#4280

Merged
joshlory merged 8 commits into
stagingfrom
chromeless-applab-share
Oct 1, 2015
Merged

[Finishes #101465756, #101453700] Chrome-less share for App Lab#4280
joshlory merged 8 commits into
stagingfrom
chromeless-applab-share

Conversation

@joshlory

@joshlory joshlory commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

This change implements chrome-less App Lab share per @sfilman's spec.

On mobile, chrome-less share shows no Run or Reset button. The app takes up the full width of the phone, with space left at the bottom (due to the aspect ratio).

screen shot 2015-09-30 at 4 34 21 pm

On desktop, chrome-less share shows no Run or Reset button. The app is framed by a phone wireframe mock.

screen shot 2015-10-01 at 11 32 01 am

joshlory
joshlory reviewed Sep 30, 2015
View reviewed changes
Comment thread dashboard/app/assets/javascripts/small_footer.js.jsx

@joshlory joshlory Sep 30, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Finishes #104218742]

@Bjvanminnen Bjvanminnen Sep 30, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah. I'd gone back and forth on using # vs. javascript:void(0). I thought I saw SO answer saying # was better, but it's been problematic in various ways. I wonder if we should be doing a broader cleanup of these.

@Bjvanminnen

Bjvanminnen commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

Pretty cool. Lgtm

@sfilman

sfilman commented Oct 1, 2015

Copy link
Copy Markdown
Contributor

Hey Josh, is the asset not sized quite correctly? Ideally we don't have the
white border around the footer and instead that butts up against the phone
border:
[image: Inline image 1]

Let me know if so and i can tweak.

On Wed, Sep 30, 2015 at 4:53 PM, Bjvanminnen notifications@github.com
wrote:

Pretty cool. Lgtm

—
Reply to this email directly or view it on GitHub
#4280 (comment)
.

@sfilman

sfilman commented Oct 1, 2015

Copy link
Copy Markdown
Contributor

Also (this looks so cool, btw!) can we push the phone down by 50 pixels so
it's not touching the browser bar?

On Wed, Sep 30, 2015 at 5:13 PM, Sarah Filman sarah.filman@code.org wrote:

Hey Josh, is the asset not sized quite correctly? Ideally we don't have
the white border around the footer and instead that butts up against the
phone border:
[image: Inline image 1]

Let me know if so and i can tweak.

On Wed, Sep 30, 2015 at 4:53 PM, Bjvanminnen notifications@github.com
wrote:

Pretty cool. Lgtm

—
Reply to this email directly or view it on GitHub
#4280 (comment)
.

joshlory pushed a commit that referenced this pull request Oct 1, 2015
Merge pull request #4280 from code-dot-org/chromeless-applab-share
43b4fc1 
[Finishes #103531916, #101453700] Chrome-less share for App Lab
@joshlory joshlory merged commit 43b4fc1 into staging Oct 1, 2015
@joshlory joshlory deleted the chromeless-applab-share branch October 1, 2015 20:51
@joshlory joshlory changed the title [Finishes #103531916, #101453700] Chrome-less share for App Lab [Finishes #101465756, #101453700] Chrome-less share for App Lab Oct 1, 2015
deploy-code-org added a commit that referenced this pull request Oct 1, 2015
@deploy-code-org
Automatically built.
7606a63 
commit 43b4fc1
Merge: 31bb729 293fde8
Author: Josh Lory <josh.lory@code.org>
Date:   Thu Oct 1 13:51:53 2015 -0700

    Merge pull request #4280 from code-dot-org/chromeless-applab-share

    [Finishes #103531916, #101453700] Chrome-less share for App Lab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Bjvanminnen Bjvanminnen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshlory @Bjvanminnen @sfilman